Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress RuboCop offense to fix broken build #3251

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

koic
Copy link
Contributor

@koic koic commented Dec 28, 2021

Follow up to #3232.

This PR suppresses the following RuboCop offense.

% bundle exec rubocop
(snip)

lib/webpacker/manifest.rb:108:107: C: [Correctable]
Layout/TrailingWhitespace: Trailing whitespace detected.
1. You forgot to install node packages (try `yarn install`) or are
running an incompatible version of Node
                                       ^

64 files inspected, 1 offense detected, 1 offense auto-correctable
Error: Process completed with exit code 1.

https://github.com/rails/webpacker/runs/4651343194

Follow up to rails#3232.

This PR suppresses the following RuboCop offense.

```console
% bundle exec rubocop
(snip)

lib/webpacker/manifest.rb:108:107: C: [Correctable]
Layout/TrailingWhitespace: Trailing whitespace detected.
1. You forgot to install node packages (try `yarn install`) or are
running an incompatible version of Node
                                       ^

64 files inspected, 1 offense detected, 1 offense auto-correctable
Error: Process completed with exit code 1.
```

https://github.com/rails/webpacker/runs/4651343194
@guillaumebriday guillaumebriday merged commit 90f0db7 into rails:master Dec 29, 2021
@koic koic deleted the suppress_rubocop_offense branch December 29, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants