provides two more common errors (fix suggestions) for Webpacker::Manifest::MissingEntryError #3232
Conversation
lib/webpacker/manifest.rb
Outdated
| 2. Your app has code with a non-standard extension (like a `.jsx` file) but the extension is not in the `extensions` config in `config/webpacker.yml` | ||
| 3. You have set compile: false (see `config/webpacker.yml`) for this environment | ||
| (unless you are using the `webpack -w` or the webpack-dev-server, in which case maybe you aren't running the dev server in the background?) | ||
| 4. Webpacker has not yet re-run to reflect updates. |
There was a problem hiding this comment.
bin/webpack not Webpacker?
There was a problem hiding this comment.
you're right it was webpack before my change on that line was idle and not intentional
|
@guillaumebriday We should merge after the comment is addressed. |
|
this is mostly about 1 and 2; 3 (was previously 1) I just cleaned up the verbiage to match "Possible causes" as it was written out of style with the others. |
lib/webpacker/manifest.rb
Outdated
| 2. webpack has not yet re-run to reflect updates. | ||
| 3. You have misconfigured Webpacker's config/webpacker.yml file. | ||
| 4. Your webpack configuration is not creating a manifest. | ||
| 1. You forgot to install node packages (try either `npm install` or `yarn install`) |
There was a problem hiding this comment.
does npm install work with webpacker?
There was a problem hiding this comment.
It should but we never mentioned it anywhere so I suggest to remove it here too
There was a problem hiding this comment.
@jasonfb this is good, but please remove the "npm" part.
@guillaumebriday I'll fix this if we don't hear from @jasonfb. This is a helpful fix.
There was a problem hiding this comment.
Hi sorry I will finish this ASAP.
|
@justin808 @guillaumebriday -- done. Can you tell me just out of curiosity why you are recommending against FYI... this was researched by (and thanks the folks who fell down this rabbit hole)... |
|
Hi @jasonfb, a number of years ago, yarn worked better. It's hard to support both equally well. If you think these could be supported equally well, please submit a PR with your justifications. |
|
Thanks @jasonfb and @justin808 |
Follow up to rails#3232. This PR suppresses the following RuboCop offense. ```console % bundle exec rubocop (snip) lib/webpacker/manifest.rb:108:107: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node ^ 64 files inspected, 1 offense detected, 1 offense auto-correctable Error: Process completed with exit code 1. ``` https://github.com/rails/webpacker/runs/4651343194
Follow up to #3232. This PR suppresses the following RuboCop offense. ```console % bundle exec rubocop (snip) lib/webpacker/manifest.rb:108:107: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node ^ 64 files inspected, 1 offense detected, 1 offense auto-correctable Error: Process completed with exit code 1. ``` https://github.com/rails/webpacker/runs/4651343194
Follow up to rails/webpacker#3232. This PR suppresses the following RuboCop offense. ```console % bundle exec rubocop (snip) lib/webpacker/manifest.rb:108:107: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node ^ 64 files inspected, 1 offense detected, 1 offense auto-correctable Error: Process completed with exit code 1. ``` https://github.com/rails/webpacker/runs/4651343194
Follow up to rails/webpacker#3232. This PR suppresses the following RuboCop offense. ```console % bundle exec rubocop (snip) lib/webpacker/manifest.rb:108:107: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. 1. You forgot to install node packages (try `yarn install`) or are running an incompatible version of Node ^ 64 files inspected, 1 offense detected, 1 offense auto-correctable Error: Process completed with exit code 1. ``` https://github.com/rails/webpacker/runs/4651343194
see https://stackoverflow.com/questions/52639256/webpackermanifestmissingentryerror