Revert of production env enforcement #2341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change made in d8dd446 forces the
production
environment on every compile, rake task and usage of the webpacker gem, ignoring the environment variables used by the system and/or developer.By retaining the original code, and defaulting to the
production
environment, it's possible for people to compile their assets and dependencies under their requirements, ensuring no breaking changes in the systems. Proper documentation can/should be added to explain the usage of theNODE_ENV
and how it affects packages for people not familiar with Node and NPM, but this change has too much breaking potential.Resolves #2340