Remove NODE_ENV declaration from rake task and production flag (#1377)

.rubocop.yml

@@ -115,7 +115,7 @@ Style/UnneededPercentQ:
 
 # Align `end` with the matching keyword or starting expression except for
 # assignments, where it should be aligned with the LHS.
-Lint/EndAlignment:
+Layout/EndAlignment:
   Enabled: true
   EnforcedStyleAlignWith: variable
 

lib/tasks/webpacker/compile.rake

@@ -1,5 +1,3 @@
-ENV["NODE_ENV"] ||= "production"
-
 $stdout.sync = true
 
 def ensure_log_goes_to_stdout
@@ -23,12 +21,14 @@ end
 namespace :webpacker do
   desc "Compile JavaScript packs using webpack for production with digests"
   task compile: ["webpacker:verify_install", :environment] do
-    ensure_log_goes_to_stdout do
-      if Webpacker.compile
-        # Successful compilation!
-      else
-        # Failed compilation
-        exit!
+    Webpacker.with_node_env("production") do
+      ensure_log_goes_to_stdout do
+        if Webpacker.compile
+          # Successful compilation!
+        else
+          # Failed compilation
+          exit!
+        end
       end
     end
   end

lib/webpacker.rb

@@ -13,6 +13,14 @@ def instance
     @instance ||= Webpacker::Instance.new
   end
 
+  def with_node_env(env)
+    original = ENV["NODE_ENV"]
+    ENV["NODE_ENV"] = "production"
+    yield
+  ensure
+    ENV["NODE_ENV"] = original
+  end
+
   delegate :logger, :logger=, :env, to: :instance
   delegate :config, :compiler, :manifest, :commands, :dev_server, to: :instance
   delegate :bootstrap, :clobber, :compile, to: :commands