Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated test files #1525

Merged
merged 1 commit into from
May 25, 2018
Merged

Remove outdated test files #1525

merged 1 commit into from
May 25, 2018

Conversation

schpet
Copy link
Contributor

@schpet schpet commented May 25, 2018

@schpet
Copy link
Contributor Author

schpet commented May 25, 2018

still working on this, one min...

@schpet
Copy link
Contributor Author

schpet commented May 25, 2018 •
edited
Loading

@gauravtiwari the docs on testing reference test.js but i think it's still legit and should probably be kept. what do you think?

https://github.com/schpet/webpacker/blob/6023c1a99690fa796a1b52464d0103d8d79f09ea/docs/testing.md

@gauravtiwari
Copy link
Member

Oh yes, let's leave it there. Thank you 💯 🍰

@gauravtiwari gauravtiwari merged commit d1016cc into rails:master May 25, 2018
@schpet schpet deleted the remove-more-test-files branch May 25, 2018 20:53
gauravtiwari added a commit that referenced this pull request Jun 10, 2018
@gauravtiwari
Revert "Remove outdated test files (#1525)"
ebcb633 
This reverts commit d1016cc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schpet @gauravtiwari