Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test environment file #1524

Merged
merged 1 commit into from
May 25, 2018

Conversation

schpet
Copy link
Contributor

@schpet schpet commented May 25, 2018

related: #1513

@gauravtiwari gauravtiwari merged commit fb7882c into rails:master May 25, 2018
@gauravtiwari
Copy link
Member

gauravtiwari commented May 25, 2018

Thanks @schpet Could you please make a PR to remove this file from installer as well? https://github.com/rails/webpacker/tree/master/lib/install/config/webpack and also test.js test in __tests__ folder.
Some references to test.js: https://github.com/rails/webpacker/blob/811796a1ba54ed98226895d5b230e9ea92d40e92/docs/testing.md

schpet added a commit to schpet/webpacker that referenced this pull request May 25, 2018
@schpet schpet deleted the remove-unused-test-file branch May 25, 2018 20:19
gauravtiwari pushed a commit that referenced this pull request May 25, 2018
KingTiger001 added a commit to KingTiger001/Rails-web-pack-project that referenced this pull request Jan 15, 2023
smartech7 pushed a commit to smartech7/ruby-webpacker that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants