Add web_console gemspec #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chancancode Was that your idea? |
gsamokovarov
force-pushed
the
web_console_gemspec
branch
7 times, most recently
from
6f5fff6 to
d6f2673
Compare
| # We need those for the testing application to run. | ||
| s.add_development_dependency "actionmailer", rails_version | ||
| s.add_development_dependency "activerecord", rails_version | ||
| For now all the functionallity is delegated, but we'll stop maintaining web-console in 3.0. |
There was a problem hiding this comment.
Idea from bcrypt-ruby/bcrypt-ruby#86
#######################################################
The `web-console` gem has been renamed to `web_console`.
Instead of installing `web-console`, you should install
`web_console`. Please update your Gemfile and other
dependencies accordingly as the legacy `web-console`
gem will not be updated after version 3.0.
#######################################################
d6f2673 to
bc28e9e
Compare
|
@chancancode @matthewd I relaxed the |
| @@ -8,20 +8,21 @@ Gem::Specification.new do |s| | |||
| s.authors = ["Charlie Somerville", "Genadi Samokovarov", "Guillermo Iguaran", "Ryan Dao"] | |||
| s.email = ["[email protected]", "[email protected]", "[email protected]"] | |||
| s.homepage = "https://github.com/rails/web-console" | |||
There was a problem hiding this comment.
If you are set on the name I can rename the repo for you so you can point to https://github.com/rails/web_console
There was a problem hiding this comment.
Back in the days I haven't read the [name your gem] guide. We have a chance of fixing the name before release. [name your gem]: http://guides.rubygems.org/name-your-gem/
gsamokovarov
force-pushed
the
web_console_gemspec
branch
from
bc28e9e to
c9cb151
Compare
|
Any objections to merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in the days I haven't read the name your gem guide. We have a
chance of fixing the name before release.