-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename gem from bcrypt-ruby to bcrypt #86
Conversation
@tmm1 @codahale I'm going to move forward with this and push a new version of the gem up now unless you have any fundamental problems with this. I'll also push a new dummy version of the gem up to the old name that depends on the new name for backwards compatibility, with a post-install message about the change. |
Awesome! Thank you. 😄 |
Okay, gem has been renamed to just @tenderlove @tmm1 @codahale You've all been added as owners of the new gem as well. A new dummy version of
|
@tenderlove @sferik @tmm1 @codahale Also, please consider retweeting this announcement if that's your thing: https://twitter.com/tjschuck/status/436971394333966336 Thanks! |
@tjschuck I couldn't find the source for the dummy gem so I couldn't issue a pull request. But a tiny change is "it's name" should be "its name" in the post-install message. |
It looks like the bcrypt-dummy gem defines the |
@nirvdrum Thanks -- will fix in a jiff. @accelecon I'm not seeing that happen... more info? |
It could be my fault; I'm still looking into it. My Gemfile.lock has:
And in rails c, I get:
|
@nirvdrum Just pushed a new version of the dummy gem to fix the typo. Thanks again. @accelecon Here's what I've got:
Lemme know if you figure out your case, or if you have steps to reproduce. |
@tjschuck Awesome. Thanks for the quick turnaround. |
@accelecon Jump over to #89 if you have any followup on the issue. |
* `bcrypt-ruby` now `bcrypt` Ref. rails/rails@53f1ab5 and bcrypt-ruby/bcrypt-ruby#86.
See bcrypt-ruby/bcrypt-ruby#86 Test plan: * specs pass Change-Id: Icb8aaaa332a6b3d9be82fb3ad76e234b66801480 Reviewed-on: https://gerrit.instructure.com/93999 Reviewed-by: Derek Bender <[email protected]> Reviewed-by: Shahbaz Javeed <[email protected]> Tested-by: Jenkins Product-Review: Neil Gupta <[email protected]> QA-Review: Neil Gupta <[email protected]>
(cherry picked from commit f4fb7b9)
It makes sense for this repository to be named
bcrypt-ruby
, to avoid ambiguity with other bcrypt libraries, but the gem name need not include-ruby
, since therubygems
package manager is tightly coupled to the Ruby language. Just as thesqlite3-ruby
gem was renamed tosqlite
, this package’s name should just bebcrypt
.This also increases consistency between the library’s name and the way it is required.
I’ve also removed links to the old RubyForge project, which no longer work.