dapp: fix moved use raiden account setting #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2722 +/- ##
==========================================
- Coverage 93.12% 93.11% -0.02%
==========================================
Files 184 184
Lines 7288 7291 +3
Branches 1216 1216
==========================================
+ Hits 6787 6789 +2
- Misses 415 416 +1
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
weilbith
force-pushed
the
bugfix/missing-adaptions-for-user-settings-store-module
branch
from
200c604
to
1da3a2b
Compare
taleldayekh
approved these changes
May 18, 2021
The root state of the store formerly included the property if the user wants to use a Raiden account or not. This was moved into the new stores submodule for the user settings. Unfortunately it was forgotten to adapt this usage in some components. This commit is fixing that. This is another indicator that our linting/type safety for pure string in regards of the Vuex store does not work. We need to find a solution for that.
weilbith
force-pushed
the
bugfix/missing-adaptions-for-user-settings-store-module
branch
from
1da3a2b
to
88c9c09
Compare
|
No CHANGELOG entry necessary for this. |
weilbith
deleted the
bugfix/missing-adaptions-for-user-settings-store-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up/fix of #2708
Short description
Our type checks for this part of the code base are horrible. We can't use refactoring tools and also linting does not find these issues.
Definition of Done
Steps to manually test the change (dApp)