Feature/dapp ethereum connection persistence #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No CHANGELOG entry needed. |
Codecov Report
@@ Coverage Diff @@
## master #2708 +/- ##
==========================================
+ Coverage 92.28% 92.35% +0.06%
==========================================
Files 179 183 +4
Lines 7245 7258 +13
Branches 1206 1208 +2
==========================================
+ Hits 6686 6703 +17
+ Misses 471 466 -5
- Partials 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
taleldayekh
approved these changes
May 7, 2021
weilbith
force-pushed
the
feature/dapp-ethereum-connection-persistence
branch
from
7b72b31
to
a2568c8
Compare
The user settings will become extended. For example it is planned to put the ethereum connection options there. This will require some additional logic and will grow over time. Therefore it make sense to export it into its own store module. Thereby we don't clutter the main store and the module can be a focused selection of storage, individually tested and maintained.
This extension of the user settings allows to make the Ethereum connection options as provided by the user can be easily preserved and reloaded. This is a preparation for the connection management by the user. For this commit the connection options are still derived from the configuration file. Later this will allows to save the users connection options and pre-fill the connection dialog, allow for auto-logins, change the options somewhere else and more.
weilbith
force-pushed
the
feature/dapp-ethereum-connection-persistence
branch
from
a2568c8
to
5e9bf59
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2689
Short description
Move user settings into a new store module. Extend user settings to include Ethereum connection options.
Definition of Done
Steps to manually test the change (dApp)