Fix mismatch between UDC totalDeposit and effectiveBalance #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
approved these changes
Oct 20, 2020
| @@ -459,13 +459,16 @@ export function monitorUdcBalanceEpic( | |||
| * etc), but merged on the top-level observable, therefore connectivity issues can cause | |||
| * exceptions which would shutdown the SDK. Let's swallow the error here, since this will be | |||
| * retried on next block, which should only be emitted after connectivity is reestablished */ | |||
| defer( | |||
There was a problem hiding this comment.
Regarding line 455: We should open an issue for the contracts to add events.
andrevmatos
force-pushed
the
fix/udc_deposit
branch
from
e735489
to
e49c217
Compare
Codecov Report
@@ Coverage Diff @@
## master #2277 +/- ##
===========================================
+ Coverage 58.12% 94.80% +36.67%
===========================================
Files 61 156 +95
Lines 4461 6271 +1810
Branches 939 1163 +224
===========================================
+ Hits 2593 5945 +3352
+ Misses 1854 261 -1593
- Partials 14 65 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request :)
Fixes #2275
Short description
udcDepositactions containedtotalDepositas solemetaproperty, but it actually was theeffectiveBalancevalue, which raised issues when calculating the new totalDeposit when making a deposit after a withdraw was performed.This PR fixes it by using actual
totalDepositas meta value (for linkingudcDepositrequests & success/failure responses), and addedbalanceto payload, to be used as UDC balance, instead of the deposit.Integration tests were extended to assert behavior when depositing after withdraw, which works as regression test for this action.
Definition of Done
Steps to manually test the change (dApp)