Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask - RPC Error: execution reverted: deposit not increasing #2275

Closed
agatsoh opened this issue Oct 20, 2020 · 1 comment · Fixed by #2277
Closed

MetaMask - RPC Error: execution reverted: deposit not increasing #2275

agatsoh opened this issue Oct 20, 2020 · 1 comment · Fixed by #2277
Assignees
Labels
bug 🕷️ Something isn't working good first issue Good for newcomers sdk 🖥

Comments

@agatsoh
Copy link
Contributor

agatsoh commented Oct 20, 2020

Thanks for filing a bug report :-)

Steps to Reproduce

  1. Deposit tokens to the UDC
    udc_deposit_screen

  2. Withdraw tokens from the UDC. They would get withdrawn to the raiden account. These tokens are kept as it is in the raiden account.

  3. Again deposit to the UDC. The UDC has 0 SVT token balance(because we just withdrew in the previous step).

execution_reverted_deposit_not_increasing

Expected Result

  • Ideally the user should be able to deposit and withdraw tokens as he wishes.

Actual Result

inpage.js:1 MetaMask - RPC Error: execution reverted: deposit not increasing {code: -32603, message: "execution reverted: deposit not increasing", data: {…}}

Additional Infos (Optional)

- Browser & version
- Browser console errors
- Device / OS
@agatsoh agatsoh added this to the Product Backlog milestone Oct 20, 2020
@andrevmatos
Copy link
Contributor

Thank you, Sohan, for this report. This is something simple which slipped through our eyes.
On

const balance = await getUdcBalance(this.deps.latest$);
we're fetching UDC balance as seen by latest$, which is the effectiveBalance. For the deposit, we must instead calculate the new total deposit based on the UDC's total_deposit method.
This is a fairly simple task. Anyone up for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🕷️ Something isn't working good first issue Good for newcomers sdk 🖥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants