Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust modifiers and add some properties to RaidenChannel & RaidenTransfer interfaces #1722

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

andrevmatos
Copy link
Contributor

Fixes #1657
Fixes #1708

Short description
RaidenChannel's id, settleTimeout and openBlock are marked as required and therefore always defined
RaidenTransfer's secret is added as optional property, and'll hold transfer's secret whenever we know it (usually true for sent transfers)

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

  1. Nothing to test, mostly types and public data adjustments

@andrevmatos andrevmatos requested a review from weilbith June 17, 2020 20:57
@andrevmatos andrevmatos self-assigned this Jun 17, 2020
@github-actions
Copy link

You modified raiden-dapp/src,
Please remember to add a change log entry at raiden-dapp/CHANGELOG.md if necessary.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1722 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1722   +/-   ##
=======================================
  Coverage   95.30%   95.31%           
=======================================
  Files         148      148           
  Lines        5330     5331    +1     
  Branches      968     1025   +57     
=======================================
+ Hits         5080     5081    +1     
  Misses        202      202           
  Partials       48       48           
Flag Coverage Δ
#dapp 91.48% <100.00%> (ø)
#sdk 96.86% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
raiden-ts/src/channels/state.ts 100.00% <ø> (ø)
raiden-ts/src/transfers/state.ts 100.00% <ø> (ø)
raiden-dapp/src/components/navigation/Channels.vue 100.00% <100.00%> (ø)
raiden-ts/src/transfers/utils.ts 93.42% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2d9ca...6153624. Read the comment docs.

Copy link
Contributor

@weilbith weilbith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quick. Really helps me out! 🙏

raiden-cli/src/utils/channels.ts Show resolved Hide resolved
@weilbith
Copy link
Contributor

If we do this quick. I can even integrate this into #1711 already and remove the issue reference.

@andrevmatos andrevmatos merged commit cbbcef5 into master Jun 18, 2020
@andrevmatos andrevmatos deleted the fix/public_ifaces branch June 18, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose transfer secret on SDK Channel identifier can be undefined by interface definition
2 participants