Implement payment routes #1711
Implement payment routes #1711
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 148 148
Lines 5322 5328 +6
Branches 1019 1022 +3
=======================================
+ Hits 5072 5078 +6
Misses 203 203
Partials 47 47
Continue to review full report at Codecov.
|
|
The referenced issue for the API spec is this one. |
|
I'm fixing the failing tests for the amount validation soon. Sorry for that. |
This includes errors for parameter that are not even used by the cli. Still this makes it complete and use the new feature of the decoding to also log these kind of errors.
This allows to do transfers as well as getting some part of the transfer history with a filter. Be aware that the API specification name it payment what the SDK calls a transfer. The code tries to make the name transition as good as it can.
The plain message that the PFS returned an error is not helpful for the user. Therefore the error details get appended in case they exist.
weilbith
force-pushed
the
feature/ci-implement-payment-routes
branch
from
1343ca6 to
69913e8
Compare
|
I rebased on |
|
@kelsos this error seem to be related to your recent PR. I must admit I can't follow this. For me it looks a bit like the restored cache for the cli does not work well with the new dependencies of the sdk. |
|
It doesn't make any sense, I just did a new PR on top of masterand it had no errors. |
|
I've seem some of those errors recently. Seems like some flakness on |
|
That is what I did. Restarted the flow. |
|
Is there a flakiness in our tests? |
Tests have been fine, there where a couple of problems with the CI flow though. In this case I am guessing it was package caching and the package installation failed. We also had an issue with the build step failing quite too often that should be fixed now. |
|
@kelsos Ok, great :) That's much more relaxing than flaky tests ;) |
|
CI has went through successful now. Could someone have a quick look and give the necessary approval to merge? |
| token_address: transfer.token, | ||
| amount: transfer.value.toString(), | ||
| identifier: transfer.paymentId.toNumber(), | ||
| secret: '', // FIXME: must be first exposed by SDK (#1708) |
There was a problem hiding this comment.
secret is already exposed
Closes: #1646
Short description
Implements the endpoints to do payments and read the payment history.
This is an "interpretation" of the current Raiden API specification. This means that there are errors defined which do not make sense or are unclear. After
a first quick discussion with the transcore team there will be an issue to discuss this topic.
Furthermore there are the new issues #1708 and #1710 as result of this work. Anyways the goal is to finalize #1646 as fast as possible with a good solution for now.
Definition of Done