Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename General screen to account #1459

Merged
merged 2 commits into from
May 4, 2020
Merged

Rename General screen to account #1459

merged 2 commits into from
May 4, 2020

Conversation

kelsos
Copy link
Contributor

@kelsos kelsos commented May 4, 2020

Fixes #1458

Short description
Renames the former General Screen to Account. With this, it also updates the components/routes/CSS etc.

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

  1. Go to the "general scree"
  2. Verify that it has been renamed to Account
  3. Routes are /account/, /account/raiden, /account/backup
  4. Everything works as before

@kelsos kelsos changed the title Light client 1458 Rename General screen to account May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1459 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
- Coverage   96.16%   96.12%   -0.05%     
==========================================
  Files         129      129              
  Lines        4853     4854       +1     
  Branches      959     1012      +53     
==========================================
- Hits         4667     4666       -1     
- Misses        138      140       +2     
  Partials       48       48              
Flag Coverage Δ
#dapp 91.62% <100.00%> (+<0.01%) ⬆️
#sdk 97.79% <ø> (-0.06%) ⬇️
#sdk_integration ?
Impacted Files Coverage Δ
raiden-dapp/src/components/AppHeader.vue 100.00% <ø> (ø)
...ponents/account/backup-state/UploadStateDialog.vue 89.65% <ø> (ø)
raiden-dapp/src/mixins/navigation-mixin.ts 100.00% <ø> (ø)
raiden-dapp/src/router/index.ts 0.00% <ø> (ø)
raiden-dapp/src/views/account/RaidenAccount.vue 96.00% <ø> (ø)
...den-dapp/src/components/account/AccountContent.vue 88.23% <100.00%> (ø)
...nents/account/backup-state/DownloadStateDialog.vue 100.00% <100.00%> (ø)
raiden-dapp/src/router/route-names.ts 100.00% <100.00%> (ø)
raiden-dapp/src/views/AccountRoute.vue 100.00% <100.00%> (ø)
raiden-dapp/src/views/account/AccountRoot.vue 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b215685...0fb8486. Read the comment docs.

Copy link
Contributor

@taleldayekh taleldayekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kelsos

@kelsos
Copy link
Contributor Author

kelsos commented May 4, 2020

@taleldayekh did you check it locally to verify that it works properly?

@kelsos kelsos merged commit 351db02 into raiden-network:master May 4, 2020
@kelsos kelsos deleted the light-client-1458 branch May 4, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename general screen to account
2 participants