Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary screen amounts expands to display exact amounts #1398

Merged
merged 14 commits into from
Apr 27, 2020

Conversation

taleldayekh
Copy link
Contributor

No description provided.

@taleldayekh taleldayekh changed the title Summart screen amounts expands to display exact amounts Summary screen amounts expands to display exact amounts Apr 23, 2020
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1398 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   96.10%   96.13%   +0.03%     
==========================================
  Files         120      121       +1     
  Lines        4721     4733      +12     
  Branches      990      939      -51     
==========================================
+ Hits         4537     4550      +13     
  Misses        135      135              
+ Partials       49       48       -1     
Flag Coverage Δ
#dapp 91.46% <100.00%> (+0.16%) ⬆️
#sdk 97.79% <ø> (ø)
Impacted Files Coverage Δ
raiden-dapp/src/components/AmountDisplay.vue 100.00% <100.00%> (ø)
raiden-dapp/src/components/FindRoutes.vue 92.30% <100.00%> (+0.30%) ⬆️
raiden-dapp/src/components/PathfindingServices.vue 90.00% <100.00%> (+3.79%) ⬆️
raiden-dapp/src/components/TokenOverlay.vue 71.42% <100.00%> (-3.58%) ⬇️
raiden-dapp/src/components/TransferSummary.vue 100.00% <100.00%> (ø)
raiden-dapp/src/views/SelectToken.vue 100.00% <100.00%> (ø)
raiden-dapp/src/views/Transfer.vue 85.71% <100.00%> (+0.25%) ⬆️
raiden-dapp/src/views/TransferSteps.vue 88.19% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba74a2...00de87d. Read the comment docs.

Copy link
Contributor

@nephix nephix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!
It probably makes sense to have an AmountDisplay component or something and use this throughout the app, instead of copy/pasting that logic everywhere

@kelsos
Copy link
Contributor

kelsos commented Apr 27, 2020

@taleldayekh I am getting the following warning in the TransferSteps is that the same for you?

[Vue warn]: Property or method "on" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <TransferSteps> at src/views/TransferSteps.vue
       <VContent>
         <VApp>
           <App> at src/App.vue
             <Root>

@taleldayekh
Copy link
Contributor Author

I am getting the following warning in the TransferSteps is that the same for you?

Give me a minute and I'll take a look.

@kelsos kelsos merged commit f96de13 into master Apr 27, 2020
@kelsos kelsos deleted the summary-total-amount branch April 27, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On hover over on Transfer Amount and Total Amount I want to see the exact value
3 participants