-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary screen amounts expands to display exact amounts #1398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 96.10% 96.13% +0.03%
==========================================
Files 120 121 +1
Lines 4721 4733 +12
Branches 990 939 -51
==========================================
+ Hits 4537 4550 +13
Misses 135 135
+ Partials 49 48 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you!
It probably makes sense to have an AmountDisplay
component or something and use this throughout the app, instead of copy/pasting that logic everywhere
@taleldayekh I am getting the following warning in the
|
Give me a minute and I'll take a look. |
No description provided.