Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On hover over on Transfer Amount and Total Amount I want to see the exact value #1381

Closed
christianbrb opened this issue Apr 21, 2020 · 4 comments · Fixed by #1398
Closed
Assignees
Labels
bug 🕷️ Something isn't working

Comments

@christianbrb
Copy link
Contributor

christianbrb commented Apr 21, 2020

Thanks for filing a bug report :-)

Steps to Reproduce

  1. Send a transfer
  2. Look at the transfer summary

Expected Result

  • On hover over on Transfer Amount and Total Amount I want to see the exact value
  • Check also other places

Actual Result

  • I see nothing on hover over

grafik

Additional Infos (Optional)

@christianbrb christianbrb added the bug 🕷️ Something isn't working label Apr 21, 2020
@christianbrb christianbrb added this to the Product Backlog milestone Apr 21, 2020
@taleldayekh taleldayekh removed this from the Product Backlog milestone Apr 23, 2020
@taleldayekh taleldayekh self-assigned this Apr 23, 2020
@taleldayekh
Copy link
Contributor

taleldayekh commented Apr 23, 2020

Should we really enable this for all amounts across the dApp?

@kelsos
Copy link
Contributor

kelsos commented Apr 24, 2020

While I certainly see a use for this. And I have seen a lot of other crypto apps dealing with a lot of decimals do it. I can certainly feel that having the hover effect when you go over the amount can be annoying.

My suggestion would be to instead add some indicator (like an *) when there are digits hidden and only show the tooltip hovering the asterisk. this way it would be less cluttered by accidental tootlips.

@christianbrb
Copy link
Contributor Author

@taleldayekh showed me his solution and it looks really nice. It is not a hover over anymore, but extending the figures at the same place on hover over.

@christianbrb
Copy link
Contributor Author

We have decided to implement it at every place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🕷️ Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants