Implement SDK error handling #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 96.18% 91.61% -4.57%
==========================================
Files 97 55 -42
Lines 3700 1062 -2638
Branches 773 118 -655
==========================================
- Hits 3559 973 -2586
+ Misses 95 58 -37
+ Partials 46 31 -15
Continue to review full report at Codecov.
|
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
e8c8dd0
to
32b1d47
Compare
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
32b1d47
to
b7a94fc
Compare
andrevmatos
reviewed
Feb 13, 2020
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
0b4dc3c
to
7b5f7aa
Compare
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
7b5f7aa
to
663e9bb
Compare
andrevmatos
reviewed
Feb 13, 2020
andrevmatos
reviewed
Feb 13, 2020
andrevmatos
reviewed
Feb 14, 2020
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
8c165a7
to
2abe85b
Compare
Co-Authored-By: André Vitor de Lima Matos <[email protected]>
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
1a37dcc
to
c48b97a
Compare
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
c48b97a
to
102033f
Compare
# Conflicts: # raiden-ts/src/channels/epics.ts # raiden-ts/tests/e2e/raiden.spec.ts
nephix
force-pushed
the
feature/sdk-custom-errors
branch
3 times, most recently
from
76ce4e4
to
35d6e56
Compare
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
35d6e56
to
d1d75af
Compare
nephix
force-pushed
the
feature/sdk-custom-errors
branch
from
d1d75af
to
20717ea
Compare
# Conflicts: # raiden-ts/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1000 (🎉)
Introduces a new
RaidenErrorclass which has an additionalcodeproperty.Example usage:
In
RaidenErrorthemessagewould be the error message targeted towards developers, while thecodewould be used display error messages to the user by e.g. hooking it up to i18n.The new error messages in t he
ErrorCodesenum should have a meaningful prefix, e.g.PFS_...for path related things orXFER_...for transfer related things.The
detailsprop is meant to be used for additional infos related to the error, e.g. transaction IDs or PFS URLs which couldn't be parsed.