Converted raiden, transport and channel errors

raiden-ts/src/channels/epics.ts

@@ -493,7 +493,10 @@ export const channelOpenEpic = (
       ).pipe(
         mergeMap(async tx => ({ receipt: await tx.wait(), tx })),
         map(({ receipt, tx }) => {
-          if (!receipt.status) throw new Error(`openChannel transaction "${tx.hash}" failed`);
+          if (!receipt.status)
+            throw new RaidenError(ErrorCodes.CNL_OPENCHANNEL_FAILED, [
+              { transactionHash: tx.hash! },
+            ]);
           return tx.hash;
         }),
         // if succeeded, return a empty/completed observable

raiden-ts/src/raiden.ts

@@ -60,6 +60,7 @@ import {
   chooseOnchainAccount,
   getContractWithSigner,
 } from './helpers';
+import RaidenError, { ErrorCodes } from './utils/error';
 
 export class Raiden {
   private readonly store: Store<RaidenState, RaidenAction>;
@@ -886,7 +887,8 @@ export class Raiden {
     const customTokenContract = CustomTokenFactory.connect(token, signer);
     const tx = await customTokenContract.functions.mint(decode(UInt(32), amount));
     const receipt = await tx.wait();
-    if (!receipt.status) throw new Error('Failed to mint token.');
+    if (!receipt.status)
+      throw new RaidenError(ErrorCodes.RDN_MINT_FAILED, [{ transactionHash: tx.hash! }]);
 
     return tx.hash as Hash;
   }
@@ -955,15 +957,15 @@ export class Raiden {
       depositAmount,
     );
     const approveReceipt = await approveTx.wait();
-    if (!approveReceipt.status) throw new Error('Approve transaction failed.');
+    if (!approveReceipt.status) throw new RaidenError(ErrorCodes.RDN_APPROVE_TRANSACTION_FAILED);
 
     const currentUDCBalance = await userDepositContract.functions.balances(this.address);
     const depositTx = await userDepositContract.functions.deposit(
       this.address,
       currentUDCBalance.add(depositAmount),
     );
     const depositReceipt = await depositTx.wait();
-    if (!depositReceipt.status) throw new Error('Deposit transaction failed.');
+    if (!depositReceipt.status) throw new RaidenError(ErrorCodes.RDN_DEPOSIT_TRANSACTION_FAILED);
 
     return depositTx.hash as Hash;
   }
@@ -998,7 +1000,7 @@ export class Raiden {
     const tx = await signer.sendTransaction({ to, value: bigNumberify(value) });
     const receipt = await tx.wait();
 
-    if (!receipt.status) throw new Error('Failed to transfer balance');
+    if (!receipt.status) throw new RaidenError(ErrorCodes.RDN_TRANSFER_ONCHAIN_BALANCE_FAILED);
     return tx.hash! as Hash;
   }
 
@@ -1030,7 +1032,7 @@ export class Raiden {
     const tx = await tokenContract.functions.transfer(to, bigNumberify(value));
     const receipt = await tx.wait();
 
-    if (!receipt.status) throw new Error('Failed to transfer tokens');
+    if (!receipt.status) throw new RaidenError(ErrorCodes.RDN_TRANSFER_ONCHAIN_TOKENS_FAILED);
     return tx.hash! as Hash;
   }
 }

raiden-ts/src/transport/epics.ts

@@ -58,6 +58,7 @@ import {
 } from 'matrix-js-sdk';
 import matrixLogger from 'matrix-js-sdk/lib/logger';
 
+import RaidenError, { ErrorCodes } from '../utils/error';
 import { Address, Signed, isntNil, assert, Signature } from '../utils/types';
 import { isActionOf } from '../utils/actions';
 import { RaidenEpicDeps } from '../types';
@@ -226,8 +227,7 @@ function searchAddressPresence$(matrix: MatrixClient, address: Address) {
     // fetch it here directly, and from now on, that other epic will monitor its
     // updates, and sort by most recently seen user
     map(presences => {
-      if (!presences.length)
-        throw new Error(`Could not find any user with valid signature for ${address}`);
+      if (!presences.length) throw new RaidenError(ErrorCodes.TRNS_NO_VALID_USER, [{ address }]);
       return minBy(presences, 'last_active_ago')!;
     }),
   );
@@ -393,7 +393,7 @@ function setupMatrixClient$(
   },
 ) {
   const serverName = getServerName(server);
-  if (!serverName) throw new Error(`Could not get serverName from "${server}"`);
+  if (!serverName) throw new RaidenError(ErrorCodes.TRNS_NO_SERVERNAME, [{ server }]);
 
   return defer(() => {
     if (setup) {
@@ -676,13 +676,13 @@ export const matrixPresenceUpdateEpic = (
       return displayName$.pipe(
         map(displayName => {
           // errors raised here will be logged and ignored on catchError below
-          if (!displayName) throw new Error(`Could not get displayName of "${userId}"`);
+          if (!displayName) throw new RaidenError(ErrorCodes.TRNS_NO_DISPLAYNAME, [{ userId }]);
           // ecrecover address, validating displayName is the signature of the userId
           const recovered = verifyMessage(userId, displayName) as Address | undefined;
           if (!recovered || recovered !== address)
-            throw new Error(
-              `Could not verify displayName signature of "${userId}": got "${recovered}"`,
-            );
+            throw new RaidenError(ErrorCodes.TRNS_USERNAME_VERIFICATION_FAILED, [
+              { userId, receivedSignature: recovered },
+            ]);
           return recovered;
         }),
         // TODO: edge case: don't emit unavailable if address is available somewhere else
@@ -1212,9 +1212,9 @@ export const matrixMessageReceivedEpic = (
               message = decodeJsonMessage(line);
               const signer = getMessageSigner(message);
               if (signer !== presence.meta.address)
-                throw new Error(
-                  `Signature mismatch: sender=${presence.meta.address} != signer=${signer}`,
-                );
+                throw new RaidenError(ErrorCodes.TRNS_MESSAGE_SIGNATURE_MISMATCH, [
+                  { sender: presence.meta.address, signer },
+                ]);
             } catch (err) {
               console.warn(`Could not decode message: ${line}: ${err}`);
               message = undefined;

raiden-ts/src/utils/error.ts

@@ -23,6 +23,7 @@ export enum ErrorCodes {
   CNL_NO_OPEN_OR_CLOSING_CHANNEL_FOUND = 'No open or closing channel has been found.',
   CNL_NO_SETTLEABLE_OR_SETTLING_CHANNEL_FOUND = 'No settleable or settling channel has been found.',
   CNL_APPROVE_TRANSACTION_FAILED = 'Token approve transaction failed.',
+  CNL_OPENCHANNEL_FAILED = 'Token networks openChannel transaction failed.',
   CNL_SETTOTALDEPOSIT_FAILED = 'Token networks setTotalDeposit transaction failed.',
   CNL_CLOSECHANNEL_FAILED = 'Token networks closeChannel transaction failed.',
   CNL_SETTLECHANNEL_FAILED = 'Token networks settleChannel transaction failed.',
@@ -31,6 +32,20 @@ export enum ErrorCodes {
   XFER_EXPIRED = 'Transfer expired.',
   XFER_CHANNEL_CLOSED_PREMATURELY = 'Channel was closed before secret got reveiled or transfer unlocked.',
   XFER_REFUNDED = 'Transfer has been refunded.',
+
+  // Transport errors
+  TRNS_NO_VALID_USER = 'Could not find a user with a valid signature.',
+  TRNS_NO_SERVERNAME = 'Could not get server name from Matrix server.',
+  TRNS_NO_DISPLAYNAME = 'Could not get display name from Matrix server.',
+  TRNS_USERNAME_VERIFICATION_FAILED = 'Could not verify the signature of a display name.',
+  TRNS_MESSAGE_SIGNATURE_MISMATCH = 'Unable to decode message due to signature mismatch.',
+
+  // Raiden main class errors
+  RDN_MINT_FAILED = 'Failed to mint tokens.',
+  RDN_APPROVE_TRANSACTION_FAILED = 'Approve transaction has failed.',
+  RDN_DEPOSIT_TRANSACTION_FAILED = 'Deposit transaction has failed.',
+  RDN_TRANSFER_ONCHAIN_BALANCE_FAILED = 'Failed to transfer on-chain balance.',
+  RDN_TRANSFER_ONCHAIN_TOKENS_FAILED = 'Failed to transfer on-chain tokens.',
 }
 
 export const ErrorDetails = t.array(t.record(t.string, t.union([t.string, t.number])));