test: fix make test fail by init sidercar test #256 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustjieke
force-pushed
the
feature_fix_init_sidecar_test_fail_#256
branch
from
6f473ae to
b4a26bb
Compare
acekingke
reviewed
Oct 12, 2021
runkecheng
approved these changes
Oct 12, 2021
andyli029
approved these changes
Oct 12, 2021
[summary]
fix bug of make test fail:
```
--- FAIL: TestGetInitSidecarEnvVar (0.00s)
init_sidecar_test.go:297:
Error Trace: init_sidecar_test.go:297
Error: Not equal:
expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)},
...
...
actual : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)},
...
...
```
related issue: radondb#116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7
[testcase]
cluster/container/init_sidecar_test.go
hustjieke
force-pushed
the
feature_fix_init_sidecar_test_fail_#256
branch
from
b4a26bb to
8695281
Compare
|
@acekingke LGTM. |
zhl003
pushed a commit
to zhl003/radondb-mysql-kubernetes
that referenced
this pull request
Aug 17, 2022
…r_test_fail_#256 test: fix make test fail by init sidercar test radondb#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes?
Fixes #256
What this PR does?
Summary:
fix bug of make test fail:
related issue: #116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7
Special notes for your reviewer?