Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] make test failed. #256

Closed
hustjieke opened this issue Oct 11, 2021 · 1 comment · Fixed by #259
Closed

[bug] make test failed. #256

hustjieke opened this issue Oct 11, 2021 · 1 comment · Fixed by #259
Assignees
@hustjieke
Labels
bug Something isn't working
Milestone
v2.1.1

Comments

@hustjieke
Copy link
Contributor

hustjieke commented Oct 11, 2021 •
edited
Loading

Describe the problem

make test:

--- FAIL: TestGetInitSidecarEnvVar (0.00s)
    init_sidecar_test.go:297: 
        	Error Trace:	init_sidecar_test.go:297
        	Error:      	Not equal: 
        	            	expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)}, 
...
...
        	            	actual  : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)}, 
...
...

To Reproduce

  1. do make test

Expected behavior

Environment:

  • RadonDB MySQL version: v2.0.0
@hustjieke hustjieke added the bug Something isn't working label Oct 11, 2021
@hustjieke hustjieke added this to the v2.1.0 milestone Oct 11, 2021
@hustjieke hustjieke self-assigned this Oct 11, 2021
@hustjieke
Copy link
Contributor Author

related issue: #116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7

@andyli029 andyli029 modified the milestones: v2.1.0, v2.1.1 Oct 12, 2021
hustjieke added a commit to hustjieke/radondb-mysql-kubernetes that referenced this issue Oct 12, 2021
@hustjieke
test: fix make test fail by init sidercar test radondb#256
6f473ae 
[summary]
fix bug of make test fail:
```
--- FAIL: TestGetInitSidecarEnvVar (0.00s)
    init_sidecar_test.go:297:
        	Error Trace:	init_sidecar_test.go:297
        	Error:      	Not equal:
        	            	expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)},
...
...
        	            	actual  : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)},
...
...
```
related issue: radondb#116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7

[testcase]
cluster/container/init_sidecar_test.go
@hustjieke hustjieke mentioned this issue Oct 12, 2021
Merged
hustjieke added a commit to hustjieke/radondb-mysql-kubernetes that referenced this issue Oct 12, 2021
@hustjieke
test: fix make test fail by init sidercar test radondb#256
b4a26bb 
[summary]
fix bug of make test fail:
```
--- FAIL: TestGetInitSidecarEnvVar (0.00s)
    init_sidecar_test.go:297:
        	Error Trace:	init_sidecar_test.go:297
        	Error:      	Not equal:
        	            	expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)},
...
...
        	            	actual  : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)},
...
...
```
related issue: radondb#116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7

[testcase]
cluster/container/init_sidecar_test.go
hustjieke added a commit to hustjieke/radondb-mysql-kubernetes that referenced this issue Oct 12, 2021
@hustjieke
test: fix make test fail by init sidercar test radondb#256
8695281 
[summary]
fix bug of make test fail:
```
--- FAIL: TestGetInitSidecarEnvVar (0.00s)
    init_sidecar_test.go:297:
        	Error Trace:	init_sidecar_test.go:297
        	Error:      	Not equal:
        	            	expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)},
...
...
        	            	actual  : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)},
...
...
```
related issue: radondb#116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7

[testcase]
cluster/container/init_sidecar_test.go
andyli029 added a commit that referenced this issue Oct 12, 2021
@andyli029
Merge pull request #259 from hustjieke/feature_fix_init_sidecar_test_…
767f476 
…fail_#256

test: fix make test fail by init sidercar test #256
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@hustjieke
test: fix make test fail by init sidercar test radondb#256
be9b108 
[summary]
fix bug of make test fail:
```
--- FAIL: TestGetInitSidecarEnvVar (0.00s)
    init_sidecar_test.go:297:
        	Error Trace:	init_sidecar_test.go:297
        	Error:      	Not equal:
        	            	expected: []v1.EnvVar{v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0x29f1540)}, v1.EnvVar{Name:"NAMESPACE", Value:"", ValueFrom:(*v1.EnvVarSource)(nil)},
...
...
        	            	actual  : []v1.EnvVar{v1.EnvVar{Name:"CONTAINER_TYPE", Value:"init-sidecar", ValueFrom:(*v1.EnvVarSource)(nil)}, v1.EnvVar{Name:"POD_HOSTNAME", Value:"", ValueFrom:(*v1.EnvVarSource)(0xc0004a87c0)},
...
...
```
related issue: radondb#116
First meet in commit: bd4fbd8
First error in commit: 46c0ce7

[testcase]
cluster/container/init_sidecar_test.go
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@andyli029
Merge pull request radondb#259 from hustjieke/feature_fix_init_sideca…
e9fd632 
…r_test_fail_#256

test: fix make test fail by init sidercar test radondb#256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustjieke hustjieke

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging a pull request may close this issue.

test: fix make test fail by init sidercar test #256 hustjieke/radondb-mysql-kubernetes
2 participants
@andyli029 @hustjieke