Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Support user management through crd. #175 #228

Merged
merged 6 commits into from
Oct 4, 2021
Merged

*: Support user management through crd. #175 #228

merged 6 commits into from
Oct 4, 2021

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Sep 22, 2021 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #150 #175 #189 #220

Previous pr：#198 #218

What this PR does?

Summary:

  • Support adding and deleting users
  • Support for user authorization (databases, tables)
  • Support modifying hosts
  • Support automatic installation of msyqluser crd
  • Add the verification of user parameters.

Special notes for your reviewer?

The main logic is in this commit:

For test:

  1. Delete the original cluster and crd, and redeploy using the test image.
    • operator image: radondb/mysql-operator:demo-921
    • sidecar image: radondb/mysql-sidecar:demo-921
  2. Make sure that the root password of the msyql cluster is set.
  3. Make sure to create user secret before creating user crd.

@runkecheng runkecheng requested review from acekingke and andyli029 and removed request for acekingke September 22, 2021 07:36
@runkecheng runkecheng added the enhancement New feature or request label Sep 22, 2021
@runkecheng runkecheng added this to the Next milestone Sep 22, 2021
@andyli029
Copy link
Contributor

andyli029 commented Sep 22, 2021 •
edited
Loading

Add another pr about SQLRunnerFactory .

andyli029
andyli029 reviewed Sep 22, 2021
View reviewed changes
internal/query.go Outdated Show resolved Hide resolved
@andyli029 andyli029 modified the milestones: Next, v2.1.0 Sep 24, 2021
@runkecheng runkecheng force-pushed the user_manager branch 6 times, most recently from 8c14b6b to 065380c Compare September 26, 2021 06:00
@acekingke
Copy link
Contributor

LGTM

andyli029
andyli029 reviewed Sep 27, 2021
View reviewed changes
utils/constants.go Outdated Show resolved Hide resolved
andyli029
andyli029 reviewed Sep 27, 2021
View reviewed changes
utils/common.go Outdated Show resolved Hide resolved
@andyli029
Copy link
Contributor

LGTM.

@andyli029 andyli029 merged commit 0cee061 into radondb:main Oct 4, 2021
@runkecheng runkecheng deleted the user_manager branch October 25, 2021 08:41
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#228 from runkecheng/user_manager
d986ca7 
*: Support user management through crd. radondb#175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@acekingke acekingke Awaiting requested review from acekingke

@hustjieke hustjieke Awaiting requested review from hustjieke

Assignees

@andyli029 andyli029

@runkecheng runkecheng

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

[feature] create crd when install operator.
4 participants
@runkecheng @andyli029 @acekingke @hustjieke