*: Support user management through crd. #175 #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runkecheng
force-pushed
the
user_crd
branch
2 times, most recently
from
08524b3 to
504e29a
Compare
runkecheng
force-pushed
the
user_crd
branch
2 times, most recently
from
de84d79 to
6bf585b
Compare
andyli029
reviewed
Sep 16, 2021
andyli029
reviewed
Sep 16, 2021
acekingke
reviewed
Sep 16, 2021
…blank line of the code block.
runkecheng
force-pushed
the
user_crd
branch
from
6bf585b to
234f625
Compare
andyli029
reviewed
Sep 18, 2021
| @@ -0,0 +1,381 @@ | |||
| /* | |||
andyli029
reviewed
Sep 18, 2021
|
|
||
| sqlRunner, err := r.getSqlRunner(ctx, user) | ||
| if err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("get sqlrunner faild, err: %s", err) |
andyli029
reviewed
Sep 18, 2021
| // 3. Set the password and permissions for the existing hosts according to the spec. | ||
| // Regardless of whether the password is modified or not, reset it to keep it up to date. | ||
| if err := r.setPassword(ctx, sqlRunner, userName, host, password); err != nil { | ||
| return fmt.Errorf("set password faild, err: %s", err) |
andyli029
reviewed
Sep 18, 2021
| host := []string{host} | ||
| // Regardless of whether the permissions is modified or not, reset it to keep it up to date. | ||
| if err := r.setPermission(ctx, sqlRunner, permissions, userName, host); err != nil { | ||
| return fmt.Errorf("set permissions faild, err: %s", err) |
andyli029
reviewed
Sep 18, 2021
| // 7. Authorize newly created user hosts. | ||
| // Ensure that the user has been successfully created before authorization. | ||
| if err := r.setPermission(ctx, sqlRunner, permissions, userName, unexistHosts); err != nil { | ||
| return fmt.Errorf("set permissions faild, err: %s", err) |
andyli029
reviewed
Sep 18, 2021
| // createUser create users in mysql based on cr information. | ||
| func (r *MysqlUserReconciler) createUser(ctx context.Context, query internal.Query, sqlRunner *internal.SQLRunner) error { | ||
| if err := sqlRunner.RunQuery(query.String(), query.Args()...); err != nil { | ||
| return fmt.Errorf("create mysql user faild, err: %s", err) |
andyli029
reviewed
Sep 18, 2021
| } | ||
|
|
||
| // If mysql user present, create or update. | ||
| cuErr := r.createOrUpdate(ctx, sqlRunner, user) |
andyli029
reviewed
Sep 18, 2021
| // 6. Add finalizer. | ||
| // 7. Authorize newly created user hosts. | ||
| // 8. Update user`s status. | ||
| func (r *MysqlUserReconciler) createOrUpdate(ctx context.Context, sqlRunner *internal.SQLRunner, mysqlUser *mysqluser.MysqlUser) error { |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/enhancement
Which issue(s) this PR fixes?
Fixes #175 #198 #189 #220
What this PR does?
Summary:
Special notes for your reviewer?
The main logic is in this commit: *: Support user management through crd. #175
For test:
radondb/mysql-operator:test-2021910radondb/mysql-sidecar:test-2021910