Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add post-start and pre-stop script #155

Merged
merged 7 commits into from
Jul 30, 2021
Merged

add post-start and pre-stop script #155

merged 7 commits into from
Jul 30, 2021

Conversation

zhyass
Copy link
Contributor

@zhyass zhyass commented Jul 27, 2021 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #135
Fixes #145
Fixes #149

What this PR does?

Summary:

  1. Generate post-start.sh script.
  2. Generate pre-stop.sh script.
  3. Add pod disruption budget.
  4. update go.mod request go 1.16+
  5. update test case
  6. Add pvc check to clean up the extra pvc.
  7. modify the rootHost's default value from 127.0.0.1 to localhost, refer: percona docker

Special notes for your reviewer?

andyli029
andyli029 reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @acekingke @runkecheng @hustjieke

acekingke
acekingke reviewed Jul 28, 2021
View reviewed changes
cluster/cluster.go Show resolved Hide resolved
cluster/syncer/statefulset.go Show resolved Hide resolved
sidecar/config.go Show resolved Hide resolved
@acekingke
Copy link
Contributor

LGTM

1 similar comment
@runkecheng
Copy link
Collaborator

LGTM

andyli029
andyli029 reviewed Jul 30, 2021
View reviewed changes
cluster/syncer/statefulset.go

ordinal, err := utils.GetOrdinal(item.Name)
if err != nil {
log.Error(err, "pvc deletion error", "key", s.Unwrap())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the log about deletion

@andyli029
Copy link
Contributor

andyli029 commented Jul 30, 2021 •
edited
Loading

pod disruption budget： https://www.jianshu.com/p/ac43a0876a5b

@acekingke
Copy link
Contributor

if do not have updatePVC， it will happe like this
image
image

Pod has changed ，but storage do not change

@andyli029
Copy link
Contributor

LGTM.

@andyli029 andyli029 merged commit fff1968 into radondb:main Jul 30, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#155 from zhyass/script
01494b2 
add post-start and pre-stop script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@acekingke acekingke acekingke left review comments

@runkecheng runkecheng Awaiting requested review from runkecheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zhyass @acekingke @runkecheng @andyli029