Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: unit test for container,cluster #130 #131

Merged
merged 1 commit into from
Jul 13, 2021
Merged

cluster: unit test for container,cluster #130 #131

merged 1 commit into from
Jul 13, 2021

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Jul 8, 2021 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

for #130，unfinished

todo: syncer

What this PR does?

PASS
coverage: 100.0% of statements
ok      github.com/radondb/radondb-mysql-kubernetes/cluster     0.280s

PASS
coverage: 100.0% of statements
ok      github.com/radondb/radondb-mysql-kubernetes/cluster/container   0.476s

Special notes for your reviewer?

@andyli029
Copy link
Contributor

fix the title:
cluster/*: unit test for container,cluster #130

@runkecheng runkecheng changed the title cluster/*: unit test for container,cluster #130 cluster: unit test for container,cluster #130 Jul 8, 2021
@andyli029 andyli029 requested review from acekingke and hustjieke July 8, 2021 06:46
@andyli029 andyli029 requested a review from zhyass July 8, 2021 07:35
acekingke
acekingke reviewed Jul 8, 2021
View reviewed changes
@runkecheng runkecheng force-pushed the unit_test branch 2 times, most recently from 6a21270 to e575eea Compare July 8, 2021 09:41
zhyass
zhyass reviewed Jul 9, 2021
View reviewed changes
zhyass
zhyass reviewed Jul 9, 2021
View reviewed changes
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 9, 2021
@zhyass
Copy link
Contributor

zhyass commented Jul 9, 2021

LGTM

@andyli029 andyli029 self-requested a review July 13, 2021 02:54
andyli029
andyli029 reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 5d04441 into radondb:main Jul 13, 2021
@andyli029 andyli029 added the enhancement New feature or request label Jul 15, 2021
@runkecheng runkecheng deleted the unit_test branch July 28, 2021 02:24
@runkecheng runkecheng restored the unit_test branch July 28, 2021 02:25
@runkecheng runkecheng deleted the unit_test branch July 28, 2021 02:29
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#131 from runkecheng/unit_test
dcf458b 
cluster: unit test for container,cluster radondb#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acekingke acekingke acekingke left review comments

@andyli029 andyli029 andyli029 left review comments

@zhyass zhyass zhyass left review comments

@hustjieke hustjieke Awaiting requested review from hustjieke

Assignees
No one assigned
Labels
enhancement New feature or request require-doc
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@runkecheng @andyli029 @zhyass @acekingke