Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add unit test #130

Closed
runkecheng opened this issue Jul 8, 2021 · 2 comments
Closed

[feature] add unit test #130

runkecheng opened this issue Jul 8, 2021 · 2 comments
Assignees
@runkecheng
Labels
enhancement New feature or request P0 High priority
Milestone
v2.0.0

Comments

@runkecheng
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

testify + mock framework(monkey/gomock/gostub)

Describe alternatives you've considered

Additional context
@runkecheng runkecheng added the enhancement New feature or request label Jul 8, 2021
@runkecheng runkecheng changed the title [feature] add the unit test [feature] add unit test Jul 8, 2021
@runkecheng runkecheng mentioned this issue Jul 8, 2021
Merged
@andyli029 andyli029 added P1 Medium priority P0 High priority and removed P1 Medium priority labels Jul 8, 2021
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 8, 2021
@andyli029 andyli029 assigned andyli029 and runkecheng and unassigned andyli029 Jul 8, 2021
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 8, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
326abbd
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 8, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
6a21270
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 8, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
e575eea
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 9, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
bef3a7a
@zhyass
Copy link
Contributor

zhyass commented Jul 9, 2021 •
edited
Loading

After add the unit test, maybe we can add Travis CI. @andyli029

runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 9, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
5823428
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this issue Jul 9, 2021
@runkecheng
cluster: unit test for container,cluster radondb#130
ef28891
@andyli029
Copy link
Contributor

andyli029 commented Jul 9, 2021 •
edited
Loading

Good job. @zhyass

andyli029 added a commit that referenced this issue Jul 13, 2021
@andyli029
Merge pull request #131 from runkecheng/unit_test
5d04441 
cluster: unit test for container,cluster #130
zhyass pushed a commit to zhyass/radondb-mysql-kubernetes that referenced this issue Jul 23, 2021
@runkecheng @zhyass
cluster: unit test for container,cluster radondb#130
12a8660
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@runkecheng
cluster: unit test for container,cluster radondb#130
07d5202
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@andyli029
Merge pull request radondb#131 from runkecheng/unit_test
dcf458b 
cluster: unit test for container,cluster radondb#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runkecheng runkecheng

Labels
enhancement New feature or request P0 High priority
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@andyli029 @zhyass @runkecheng