Only when backup is going, rollingup updating should pause #790

radondb · May 30, 2023 · 174b801 · 174b801
1 parent a200843
commit 174b801
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/api/v1beta1/zz_generated.conversion.go b/api/v1beta1/zz_generated.conversion.go
diff --git a/controllers/backup/backup_controller.go b/controllers/backup/backup_controller.go
@@ -29,6 +29,7 @@ import (
 	"k8s.io/apimachinery/pkg/api/equality"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/client-go/tools/record"
@@ -205,7 +206,12 @@ func (r *BackupReconciler) reconcileManualBackup(ctx context.Context,
 	backup *v1beta1.Backup, manualBackupJobs []*batchv1.Job, cluster *v1beta1.MysqlCluster) error {
 	manualStatus := backup.Status.ManualBackup
 	var currentBackupJob *batchv1.Job
-
+	if len(backup.ObjectMeta.Labels["cluster"]) == 0 {
+		backup.ObjectMeta.Labels = labels.Set{"cluster": backup.Spec.ClusterName}
+		if err := r.Update(ctx, backup); err != nil {
+			return err
+		}
+	}
 	if backup.Spec.BackupSchedule != nil {
 		// if the backup is a scheduled backup, ignore manual backups
 		return nil