Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Address.parseAddress can handle quoted IPv6 addresses #386

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

michaelklishin
Copy link
Member

Proposed Changes

This makes Address.parseAddress handle quoted IPv6 addresses the same way Bunny does.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Address parser is incapable of handling IPv6 address literals #385)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #385.

[#159499428]

@michaelklishin michaelklishin merged commit d373d45 into master Aug 2, 2018
@michaelklishin michaelklishin deleted the rabbitmq-java-client-385 branch August 2, 2018 16:22
@michaelklishin
Copy link
Member Author

@acogoluegnes what branches would you like me to backports this to?

@acogoluegnes
Copy link
Contributor

@michaelklishin 4.x.x-stable and 5.x.x-stable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address parser is incapable of handling IPv6 address literals
2 participants