Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address parser is incapable of handling IPv6 address literals #385

Closed
michaelklishin opened this issue Aug 1, 2018 · 0 comments · Fixed by #386
Closed

Address parser is incapable of handling IPv6 address literals #385

michaelklishin opened this issue Aug 1, 2018 · 0 comments · Fixed by #386
Labels
bug effort-low usability
Milestone
4.8.0

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Aug 1, 2018 •
edited
Loading

Originally reported in ruby-amqp/march_hare#134. Address.parseAddress currently assumes a hostname:port pair and IPv4 addresses.

The same issue was addressed in Bunny a couple of years ago, we should do the same thing: require IPv6 addresses to be enclosed in square brackets.
This was referenced Aug 1, 2018
Closed
Closed
@acogoluegnes acogoluegnes added this to the 4.8.0 milestone Aug 2, 2018
michaelklishin added a commit that referenced this issue Aug 2, 2018
@michaelklishin
Make sure Address.parseAddress can handle quoted IPv6 addresses
d282928 
Closes #385.

[#159499428]
@michaelklishin michaelklishin mentioned this issue Aug 2, 2018
Merged
11 tasks
michaelklishin added a commit that referenced this issue Aug 2, 2018
@michaelklishin
Make sure Address.parseAddress can handle quoted IPv6 addresses
1ba531b 
Closes #385.

[#159499428]

(cherry picked from commit d282928)
michaelklishin added a commit that referenced this issue Aug 2, 2018
@michaelklishin
Make sure Address.parseAddress can handle quoted IPv6 addresses
5677b79 
Closes #385.

[#159499428]

(cherry picked from commit d282928)
This was referenced Mar 16, 2021
Closed
Closed
Open
@bantu bantu mentioned this issue Sep 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort-low usability
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Make sure Address.parseAddress can handle quoted IPv6 addresses rabbitmq/rabbitmq-java-client
2 participants
@michaelklishin @acogoluegnes