-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate clients #87
Generate clients #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the script hack/update-codegen.sh
need to be added to the make generate
target?
Does kubebuilder now encourage a Makefile? This has been seen as an anti-pattern in many projects, including Knative. |
@MirahImage Thanks, PTAL. Added update-codegen.sh to make generate, and re-ran it to make sure it worked.
|
This was introduced part of #87, and in the latest eventing-rabbitmq changes it became obvious that the versions started to drift. This discussion explains the problem best: #256 This holds the rest of the context: knative-extensions/eventing-rabbitmq#492 (comment) This change lines up all versions, and the local unit & integration tests pass. My next step is to check if CI remains green, and if the change actually works in the context of eventing-rabbitmq, which is how this started. Signed-off-by: Gerhard Lazu <[email protected]>
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Add codegen generated clients so that these can be used from things like github.com/knative-sandbox/eventing-rabbitmq. While it seems like a lot of new code, it's all code generated. Also had to fix couple of tags / add methods in the api/v1alpha2 so the code-gen behaves properly.
Start of the usage can be seen here (by no means complete, just starting that work over there):
knative-extensions/eventing-rabbitmq#267
Additional Context