Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in the rabbit messaging topology operator, generate injection, wire things through. #267

Merged
merged 17 commits into from
Apr 2, 2021

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 26, 2021

Changes

  • Start wiring up the rabbitmq CRDs.
  • Generate necessary injection clients for our reconcilers
  • Wire enough stuff through that we can checkpoint and start the parallel implementation work with CRD based next to library based implementation.
  • Does NOT use the CRD implementation yet. That's followup on purpose to keep this to a (semi)sane size.

/kind

Fixes #

Release Note


Docs


@vaikas vaikas requested review from a team as code owners March 26, 2021 18:18
@vaikas vaikas requested review from a team March 26, 2021 18:18
@knative-prow-robot
Copy link

@vaikas: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Start wiring up the rabbitmq CRDs. Does not really do anything useful yet, just getting the types in and playing with it.

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 26, 2021
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2021
@vaikas vaikas force-pushed the use-operator-crds branch from bf05c41 to ee14992 Compare March 29, 2021 21:09
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2021
@vaikas vaikas force-pushed the use-operator-crds branch from 084f357 to f75e8b4 Compare March 31, 2021 23:05
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #267 (d8fbc74) into main (1730869) will decrease coverage by 2.07%.
The diff coverage is 45.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   72.01%   69.94%   -2.08%     
==========================================
  Files          28       28              
  Lines        1451     1517      +66     
==========================================
+ Hits         1045     1061      +16     
- Misses        324      373      +49     
- Partials       82       83       +1     
Impacted Files Coverage Δ
pkg/apis/duck/v1beta1/rabbit.go 0.00% <ø> (ø)
pkg/reconciler/broker/broker_config.go 39.65% <0.00%> (ø)
pkg/reconciler/broker/resources/exchange.go 43.63% <0.00%> (-26.96%) ⬇️
pkg/reconciler/broker/broker.go 68.02% <50.00%> (-10.87%) ⬇️
pkg/reconciler/broker/broker_test_helper.go 75.86% <100.00%> (+0.86%) ⬆️
pkg/reconciler/broker/controller.go 96.72% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1730869...d8fbc74. Read the comment docs.

@vaikas vaikas changed the title [WIP] bring in the rabbit client, DOES NOT WORK YET Bring in the rabbit messaging topology operator, generate injection, wire things through. Apr 1, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2021
n3wscott
n3wscott previously approved these changes Apr 2, 2021
Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

holding for test results

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2021
@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2021
@vaikas vaikas removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2021
Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ca7bfc5 into knative-extensions:main Apr 2, 2021
@vaikas vaikas deleted the use-operator-crds branch April 2, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants