-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing olm #767
Testing olm #767
Conversation
2062a61
to
75dccef
Compare
9e12bbf
to
faf40dc
Compare
faf40dc
to
f1c93a7
Compare
33b982f
to
c64b43a
Compare
c64b43a
to
71feecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are still working on this PR 🚧 A suggestion, can we use the Checkout Action instead of git clone
?
It's a bit hard to understand and read through the "create" task with all the setup intertwined with the actual commands to generate the bundle.
This hasn't updated in a long time, but perhaps it still creates the bundle that we can use? |
@Zerpet yes it is nicer to use checkout, I will fix it. About this https://github.com/marketplace/actions/olm-bundle it is quite interesting. If the action is working we can use directly that one avoiding to refactor and maintaining that script which is good. |
8e37ad6
to
e918304
Compare
e918304
to
ff74b17
Compare
I replaced the git clones with the better checkout actions and I have tested it. I will now merge this one to test it on the next release. We can come back here when we will improve the OLM packaging script. |
Similar to rabbitmq/cluster-operator#1569.
This PR is part of the task to migrate our Concourse pipelines to github actions:
It is migrating the OLM pipeline in order to test our OLM bundle in the messaging-topology-operator:
https://github.com/pivotal/rabbitmq-for-kubernetes-ci/blob/main/pipelines/olm-bundles/pipeline.yml
it can be useful to have a look to this guideline in order to see how to create and publish an OLM bundle:
https://devopstales.github.io/home/oml/
The test images are stored in the environment variable specified in:
DOCKER_REGISTRY_SERVER: quay.io/rabbitmqoperator
OLM_IMAGE: rabbitmq-for-kubernetes-olm-messaging-topology-operator
OLM_INDEX_IMAGE: rabbitmq-for-kubernetes-olm-messaging-topology-operator-index