-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating OLM testing pipeline from concourse to github-action #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
changed the title
Testing olm
Migrating OLM testing pipeline from concourse to github-action
Feb 26, 2024
DanielePalaia
force-pushed
the
testing_olm
branch
from
February 26, 2024 16:27
adcf9dd
to
12ce96d
Compare
PujaVad
reviewed
Feb 27, 2024
DanielePalaia
force-pushed
the
testing_olm
branch
2 times, most recently
from
March 1, 2024 13:24
6466949
to
c117a1f
Compare
DanielePalaia
force-pushed
the
testing_olm
branch
from
March 1, 2024 13:41
c117a1f
to
9668d71
Compare
Taking in account Aitor review here: rabbitmq/OLM-Package-Repo#8 |
DanielePalaia
force-pushed
the
testing_olm
branch
6 times, most recently
from
March 6, 2024 11:07
4bb681e
to
6bb0446
Compare
DanielePalaia
force-pushed
the
testing_olm
branch
from
March 6, 2024 11:47
6bb0446
to
1274c76
Compare
DanielePalaia
force-pushed
the
testing_olm
branch
3 times, most recently
from
March 7, 2024 11:20
fa6b04b
to
284e775
Compare
DanielePalaia
force-pushed
the
testing_olm
branch
from
March 7, 2024 13:03
284e775
to
9e4042e
Compare
I replaced git clone with checkout actions here too like suggested here: rabbitmq/messaging-topology-operator#767. I will merge this one now to test it on the next operator release. We can come back with improments here when we improve the OLM Packaging script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the task to migrate our Concourse pipelines to github actions:
It is migrating the OLM pipeline in order to test our OLM bundle in the cluster-operator:
https://github.com/pivotal/rabbitmq-for-kubernetes-ci/blob/main/pipelines/olm-bundles/pipeline.yml
it can be useful to have a look to this guideline in order to see how to create and publish an OLM bundle:
https://devopstales.github.io/home/oml/
The test images are stored in the environment variable specified in:
DOCKER_REGISTRY_SERVER: quay.io/rabbitmqoperator
OLM_IMAGE: rabbitmq-for-kubernetes-olm-cluster-operator
OLM_INDEX_IMAGE: rabbitmq-for-kubernetes-olm-cluster-operator-index
The action is always testing the latest cluster operator manifest (the last tagged version).
In case we run the action manually (through a workflow_dispatch) a generic 0.0.0 tag version is generated.
The cluster operator is deployed and configured in order to watch just on "rabbitmq-system-olm" namespace so that the K8s cluster can be shared with the action which is testing the deployment using the carvel Package Repository (which is deploying the cluster operator and watching in the default "rabbitmq-system" namespace)
The lock is needed in order to share the cluster with the future messaging topology operator action.
The create-olm-package job is a bit confusing and overcomplicated but this will be improved when we will improve the conversion bundle script in python.
The new action and the old publishing action (openshift.yml) have been merged together.
Action result here: https://github.com/rabbitmq/cluster-operator/actions/runs/8052246499
Manifests are uploaded here:
https://github.com/rabbitmq/community-operators (operator-hub)
https://github.com/rabbitmq/community-operators-prod (openshift-marketplace)
Then a manual PR to openshfit repos is needed