Do not requeue error when disableNonTLSListen is misconfigured #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- true but TLS is not enabled; this is a user confguration error and need to be fixed by user updating the rabbitmqcluster - reconcileTLS returns a special error so the controller will exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #884
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
disableNonTLSListenis set to true but TLS is not enabled; this is a user configuration error and need to be fixed by user updating rabbitmqcluster manifest which will trigger reconcile anywaysreconcileTLS()returns a special errordisableNonTLSConfigErr.Reconcile()identifies the error and exit the reconcile so no k8s resource is created for the misconfigured rabbitmqcluster.Additional Context
Local Testing