Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX when Disable non-TLS listeners is true and TLS is not configured #884

Closed
Zerpet opened this issue Oct 28, 2021 · 0 comments · Fixed by #887
Closed

Improve UX when Disable non-TLS listeners is true and TLS is not configured #884

Zerpet opened this issue Oct 28, 2021 · 0 comments · Fixed by #887
Labels
enhancement New feature or request

Comments

@Zerpet
Copy link
Collaborator

Zerpet commented Oct 28, 2021

The following YAML can be applied successfully:

apiVersion: rabbitmq.com/v1beta1
kind: RabbitmqCluster
metadata:
  name: my-rabbitmqcluster
spec:
  replicas: 1
  tls:
    disableNonTLSListeners: true

The operator will return an error in the reconcile loop, and it will try infinitely. We know this can't succeed, therefore we shouldn't retry. We should log the error, as we currently do, set a status condition reflecting this problem, and stop requeueing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant