-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to v1.14.0 #41
chore: upgrade to v1.14.0 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be sensible to ship the template wiith MigrateToLatestXcmVersion
baked into the runtime.
I'd like to read others opinions, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see dependencies that are bumped when looking at the Cargo.toml file of the SDK on release v1.14 (e.g. codec = 3.6.12), compared to the ones here. Please compare the ones above line 40 (#Substrate
).
service.rs:
+use prometheus_endpoint::Registry;
-use substrate_prometheus_endpoint::Registry;
runtime/src/config/mod.rs:
message_queue
- type HeapSize = sp_core::ConstU32<{ 64 * 1024 }>;
+ type HeapSize = sp_core::ConstU32<{ 103 * 1024 }>;
xcm.rs
- type FeeManager = XcmFeeManagerFromComponents<
- WaivedLocations,
- // Delivery fees are sent to the treasury account.
- // These funds are not accessible without a module controlling such an account.
- // [pallet_treasury](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/treasury)
- // could be suitable option, configured using the same `TREASURY_PALLET_ID` used above as the pallet config's `PalletId`.
- XcmFeeToAccount<Self::AssetTransactor, AccountId, TreasuryAccount>,
- >;
+ type FeeManager = ();
- type XcmTeleportFilter = Nothing;
+ type XcmTeleportFilter = Everything;
Could be sensible to ship the template wiith MigrateToLatestXcmVersion baked into the runtime.
I see no harm in putting it in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find anything more than what Daan has spotted.
Left a pair of super small nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from ale's comments the chain runs smoothly and seems good to go!
Status: ✅ Compiled and built successfully
ISSUE: chore: upgrade polkadot version to v1.14.0 #39
Release: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.14.0
Compare Parachain Template v1.13.0 vs Parachain Template v1.14.0
Direct changes
runtime
macroRuntimeFreezeReason
: paritytech/polkadot-sdk@988103d