Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to v1.14.0 #41

Merged

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 16, 2024

Status: ✅ Compiled and built successfully

Direct changes

Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be sensible to ship the template wiith MigrateToLatestXcmVersion baked into the runtime.

I'd like to read others opinions, though.

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see dependencies that are bumped when looking at the Cargo.toml file of the SDK on release v1.14 (e.g. codec = 3.6.12), compared to the ones here. Please compare the ones above line 40 (#Substrate).

service.rs:

+use prometheus_endpoint::Registry;
-use substrate_prometheus_endpoint::Registry;

runtime/src/config/mod.rs:

message_queue
-    type HeapSize = sp_core::ConstU32<{ 64 * 1024 }>;
+    type HeapSize = sp_core::ConstU32<{ 103 * 1024 }>;

xcm.rs

-    type FeeManager = XcmFeeManagerFromComponents<
-        WaivedLocations,
-        // Delivery fees are sent to the treasury account.
-        // These funds are not accessible without a module controlling such an account.
-        // [pallet_treasury](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/treasury)
-        // could be suitable option, configured using the same `TREASURY_PALLET_ID` used above as the pallet config's `PalletId`.
-        XcmFeeToAccount<Self::AssetTransactor, AccountId, TreasuryAccount>,
-    >;
+    type FeeManager = ();

-    type XcmTeleportFilter = Nothing;
+    type XcmTeleportFilter = Everything;

Could be sensible to ship the template wiith MigrateToLatestXcmVersion baked into the runtime.

I see no harm in putting it in there.

Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything more than what Daan has spotted.
Left a pair of super small nits.

runtime/src/configs/xcm.rs Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from ale's comments the chain runs smoothly and seems good to go!

@Daanvdplas Daanvdplas merged commit 16a7ef2 into r0gue-io:main Aug 20, 2024
5 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-polkadot-v1.14.0 branch August 21, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants