Use real rust type for pallet alias in `runtime` macro #4769

gupnik · 2024-06-12T04:22:23Z

Fixes #4723. Also, closes #4622

As stated in the linked issue, this PR adds the ability to use a real rust type for pallet alias in the new runtime macro:

#[runtime::pallet_index(0)]
pub type System = frame_system::Pallet<Runtime>;

Please note that the current syntax still continues to be supported.

CC: @shawntabrizi @kianenigma

shawntabrizi

lgtm high level

kianenigma

Loogs good, except the doc for #[runtime] macro are not updated.

I also wanted to log this for you in a new issue that I have not done so far:

The docs for frame::runtime, unlike almost all other frame macros, live in the procedural crate, and therefore is ignore-ed code. It would align with our standards better to move them to where it is being re-exported so the code snippets can be live.

…ik/runtime-updates

substrate/frame/support/src/lib.rs

shawntabrizi · 2024-06-17T12:05:26Z

Is this syntax supported?

///   // Pallet with instance.
///   #[runtime::pallet_index(2)]
///   pub type Test2_Instance1 = test2::Pallet<Runtime, Instance1>;

This is what I would expect for Pallet<T, I>

gupnik · 2024-06-17T13:08:45Z

Is this syntax supported?
///   // Pallet with instance.
///   #[runtime::pallet_index(2)]
///   pub type Test2_Instance1 = test2::Pallet<Runtime, Instance1>;
This is what I would expect for Pallet<T, I>

Yes, this is the way its added now. Will add this in the docify example as well.

substrate/frame/support/procedural/src/lib.rs

gupnik · 2024-06-19T05:39:30Z

bot fmt

command-bot · 2024-06-19T05:39:35Z

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6499660 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-7fceaa54-0ccd-487b-94ac-62f9f9f56566 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-06-19T05:41:26Z

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6499660 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6499660/artifacts/download.

prdoc/pr_4769.prdoc

templates/minimal/runtime/src/lib.rs

substrate/frame/support/src/lib.rs

substrate/frame/support/procedural/src/runtime/parse/pallet_decl.rs

substrate/frame/support/procedural/src/runtime/parse/pallet.rs

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

…ik/runtime-updates

paritytech-cicd-pr · 2024-06-25T04:49:20Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6537108

@shawntabrizi

Fixes paritytech#4723. Also, closes paritytech#4622 As stated in the linked issue, this PR adds the ability to use a real rust type for pallet alias in the new `runtime` macro: ```rust #[runtime::pallet_index(0)] pub type System = frame_system::Pallet<Runtime>; ``` Please note that the current syntax still continues to be supported. CC: @shawntabrizi @kianenigma --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <[email protected]>

Use real rust for pallet type in macro

3dc0fc7

gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jun 12, 2024

gupnik requested a review from a team as a code owner June 12, 2024 04:22

Removes Cargo.lock changes

bcd9764

shawntabrizi approved these changes Jun 12, 2024

View reviewed changes

kianenigma reviewed Jun 13, 2024

View reviewed changes

gupnik added 2 commits June 17, 2024 17:02

Moves docs

4e75f14

Merge branch 'master' of github.com:paritytech/polkadot-sdk into gupn…

f872a3d

…ik/runtime-updates

shawntabrizi reviewed Jun 17, 2024

View reviewed changes

substrate/frame/support/src/lib.rs Outdated Show resolved Hide resolved

muharem reviewed Jun 17, 2024

View reviewed changes

substrate/frame/support/procedural/src/lib.rs Show resolved Hide resolved

Uses docify for runtime macro docs

b4c7a67

paritytech-review-bot bot requested a review from a team June 19, 2024 05:34

Adds PrDoc

c5d95df

".git/.scripts/commands/fmt/fmt.sh"

5243881

Updates PrDoc

639d37a

gupnik commented Jun 20, 2024

View reviewed changes

prdoc/pr_4769.prdoc Outdated Show resolved Hide resolved

Update prdoc/pr_4769.prdoc

c2319ec

ggwpez reviewed Jun 20, 2024

View reviewed changes

templates/minimal/runtime/src/lib.rs Show resolved Hide resolved

bkchr reviewed Jun 20, 2024

View reviewed changes

gupnik and others added 4 commits June 21, 2024 15:20

Update substrate/frame/support/procedural/src/runtime/parse/pallet_de…

217ff38

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/frame/support/procedural/src/runtime/parse/pallet_de…

0d364d0

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/frame/support/procedural/src/runtime/parse/pallet_de…

3426122

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/frame/support/procedural/src/runtime/parse/pallet_de…

059cbb9

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

paritytech-review-bot bot requested a review from a team June 21, 2024 13:21

Update substrate/frame/support/procedural/src/runtime/parse/pallet_de…

80afc50

…cl.rs Co-authored-by: Bastian Köcher <[email protected]>

gupnik added 4 commits June 25, 2024 10:01

Addresses review comments

465b58e

FMT

4617117

Merge branch 'master' of github.com:paritytech/polkadot-sdk into gupn…

4f1c265

…ik/runtime-updates

Updates docs

4e859b0

gupnik added 3 commits June 25, 2024 11:36

Reuses code and adds tests

05b9f41

Makes taplo happy

91fb52e

FMT

df00488

bkchr approved these changes Jun 25, 2024

View reviewed changes

gupnik requested review from ggwpez, kianenigma and muharem June 25, 2024 11:09

muharem approved these changes Jun 25, 2024

View reviewed changes

gupnik added this pull request to the merge queue Jun 25, 2024

Merged via the queue into master with commit 2f3a1bf Jun 25, 2024
160 of 163 checks passed

gupnik deleted the gupnik/runtime-updates branch June 25, 2024 15:03

This was referenced Aug 16, 2024

chore: upgrade to v1.14.0 r0gue-io/base-parachain#41

Merged

chore: upgrade v1.14.0 r0gue-io/pop-node#198

Merged

github-actions bot mentioned this pull request Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Closed

This was referenced Aug 21, 2024

chore: upgrade to polkadot v1.14.0 r0gue-io/assets-parachain#8

Merged

chore: upgrade to polkadot v1.14.0 r0gue-io/contracts-parachain#9

Merged

github-actions bot mentioned this pull request Aug 22, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

TDemeco mentioned this pull request Oct 7, 2024

feat: ⏫ upgrade to Polkadot SDK v1.14.0 Moonsong-Labs/storage-hub#218

Merged

Aideepakchaudhary mentioned this pull request Oct 23, 2024

Feat: Polkadot v1.12 to v1.14 upgrade Cerebellum-Network/blockchain-node#454

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use real rust type for pallet alias in `runtime` macro #4769

Use real rust type for pallet alias in `runtime` macro #4769

gupnik commented Jun 12, 2024 •

edited

Loading

shawntabrizi left a comment

kianenigma left a comment

shawntabrizi commented Jun 17, 2024

gupnik commented Jun 17, 2024

gupnik commented Jun 19, 2024

command-bot bot commented Jun 19, 2024 •

edited

Loading

command-bot bot commented Jun 19, 2024

paritytech-cicd-pr commented Jun 25, 2024

Use real rust type for pallet alias in runtime macro #4769

Use real rust type for pallet alias in runtime macro #4769

Conversation

gupnik commented Jun 12, 2024 • edited Loading

shawntabrizi left a comment

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

shawntabrizi commented Jun 17, 2024

gupnik commented Jun 17, 2024

gupnik commented Jun 19, 2024

command-bot bot commented Jun 19, 2024 • edited Loading

command-bot bot commented Jun 19, 2024

paritytech-cicd-pr commented Jun 25, 2024

Use real rust type for pallet alias in `runtime` macro #4769

Use real rust type for pallet alias in `runtime` macro #4769

gupnik commented Jun 12, 2024 •

edited

Loading

command-bot bot commented Jun 19, 2024 •

edited

Loading