Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant support #147

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add variant support #147

merged 1 commit into from
Oct 25, 2024

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Oct 22, 2024

Closes #125.

@lionel- lionel- requested a review from hadley October 22, 2024 13:15
hadley
hadley approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems simple enough 😆

@lionel- lionel- merged commit 26787b5 into main Oct 25, 2024
13 checks passed
@lionel- lionel- deleted the feature/variant branch October 25, 2024 07:31
@danielinteractive
Copy link

Awesome! Thanks so much @lionel-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a variant support for snapshots?
3 participants
@lionel- @danielinteractive @hadley