Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a variant support for snapshots? #125

Closed
danielinteractive opened this issue Oct 31, 2022 · 2 comments · Fixed by #147
Closed

Adding a variant support for snapshots? #125

danielinteractive opened this issue Oct 31, 2022 · 2 comments · Fixed by #147

Comments

@danielinteractive
Copy link

Hello team,
first of all thanks for vdiffr- very important for the testing of plot functions.
One question - did you consider already adding variant support similar as shinytest2 e.g. has?
That could come in handy to save snapshots from different ggplot2 package versions e.g.

@lionel-
Copy link
Member

lionel- commented Nov 2, 2022

yes in fact part of the motivation for adding a variant mechanism in testthat was to support multiple svg snapshots for different R versions..

@lionel-
Copy link
Member

lionel- commented Oct 31, 2024

Now on CRAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants