Fix MD link test case #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #809. Do not regex match XML, that was a bad idea.
|
Thanks! Sorry for not catching this during the commonmark release. |
|
Thanks - I'll try and get a release out later today |
|
@hadley oh, this is just in the tests, nothing is broken in roxygen itself. So just for this it is not urgent. |
|
I have something else I'd like to track down (which is how I came across this). If CRAN isn't bothered yet, maybe a release could wait a bit? |
|
There are other problems which mean I'd rather get a release out sooner rather than later. I'm also happy to look into your problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #809. Do not regex match XML, that was a bad idea.