Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in roxygen2 #11

Closed
jennybc opened this issue Oct 23, 2018 · 3 comments
Closed

Tests failing in roxygen2 #11

jennybc opened this issue Oct 23, 2018 · 3 comments

Comments

@jennybc
Copy link
Member

jennybc commented Oct 23, 2018

I first saw this locally then checked that same is happening on CRAN. Something about the most recent common mark release seems to have changed behaviour that is tested in roxygen2.

https://cran.r-project.org/web/checks/check_results_roxygen2.html

@jennybc
Copy link
Member Author

jennybc commented Oct 23, 2018

A bit more info from a test case. commonmark::markdown_xml("foo [func()] bar") is returning:

<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n
<!DOCTYPE document SYSTEM \"CommonMark.dtd\">\n
<document
	xmlns=\"http://commonmark.org/xml/1.0\">\n  
	<paragraph>\n    
		<text xml:space=\"preserve\">foo </text>\n    
		<link destination=\"R:func()\" title=\"\">\n      
			<text xml:space=\"preserve\">func()</text>\n    
		</link>\n    
		<text xml:space=\"preserve\"> bar</text>\n  
	</paragraph>\n
</document>\n

whereas the expectation (previous behaviour?) is:

<link destination=\"R:func\\(\\)\" title=\"\">\\s*
	<text>func\\(\\)</text>

Not sure who needs to adjust to whom here.

@jennybc
Copy link
Member Author

jennybc commented Oct 23, 2018

cc @gaborcsardi

@jeroen
Copy link
Member

jeroen commented Oct 23, 2018

Fixed via r-lib/roxygen2#811

@jeroen jeroen closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants