Change cli arguments parser to kingpin, add short commands #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sponomarev
force-pushed
the
feature/short-cli-commands
branch
from
e6e5ec9
to
6f420db
Compare
qustavo
requested changes
Sep 29, 2017
cmd/httplab/main.go
Outdated
| cors bool | ||
| config = kingpin.Flag("config", "Specifies custom config path.").Short('c').String() | ||
| cors = kingpin.Flag("cors", "Enable CORS").Default("false").Bool() | ||
| port = kingpin.Flag("port", "Specifies the port where HTTPLab will bind to.").Default("false").Default("10080").Int() |
cmd/httplab/main.go
Outdated
| config = kingpin.Flag("config", "Specifies custom config path.").Short('c').String() | ||
| cors = kingpin.Flag("cors", "Enable CORS").Default("false").Bool() | ||
| port = kingpin.Flag("port", "Specifies the port where HTTPLab will bind to.").Default("false").Default("10080").Int() | ||
| bindings = kingpin.Flag("bindings", "Show keyboard bindings").Bool() |
There was a problem hiding this comment.
shouldn't we keep -h for this one?
sponomarev
force-pushed
the
feature/short-cli-commands
branch
from
6f420db
to
e0fb9bd
Compare
|
@gchaincl Done! Please, take a look! |
|
@sponomarev thanks for this, but I'm closing this in favour of #50, it kept the original behavior which was to display the bindings information along the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49