Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add short flags #50

Merged
merged 2 commits into from
Oct 2, 2017
Merged

add short flags #50

merged 2 commits into from
Oct 2, 2017

Conversation

dnguy078
Copy link
Contributor

@dnguy078 dnguy078 commented Sep 28, 2017 •
edited
Loading

#49 - Support for short flags

@dnguy078 dnguy078 mentioned this pull request Sep 28, 2017
Closed
qustavo
qustavo requested changes Sep 29, 2017
View reviewed changes
Copy link
Owner

@qustavo qustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, super simple!
Can u update README.md with the new flag format?
Also, seems that you've just copied pflag to vendors, mind to use govendor update +e instead?

@dnguy078
Copy link
Contributor Author

@gchaincl Thanks! I updated the README.md and used govendor to add pflag

@qustavo qustavo merged commit efe3e63 into qustavo:master Oct 2, 2017
@qustavo qustavo mentioned this pull request Oct 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qustavo qustavo qustavo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnguy078 @qustavo