Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page bookmarks not working in some cases #2998

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix page bookmarks not working in some cases #2998

merged 1 commit into from
Dec 5, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 5, 2024

This patch fixes page bookmarks. Due to recent refactoring to make the
bookmarks observable, bookmarking a page and then swiping a few pages in
either direction and coming back would cause the bookmark to flicker and
then come back. This is because the logic to refresh the bookmark status
in onPrepareOptionsMenu was removed during the refactoring. This patch
adds it back.

This patch fixes page bookmarks. Due to recent refactoring to make the
bookmarks observable, bookmarking a page and then swiping a few pages in
either direction and coming back would cause the bookmark to flicker and
then come back. This is because the logic to refresh the bookmark status
in onPrepareOptionsMenu was removed during the refactoring. This patch
adds it back.
Copy link

github-actions bot commented Dec 5, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  24.1 MiB │  24.1 MiB │ +420 B │  74.7 MiB │  74.7 MiB │ +872 B 
     arsc │   2.7 MiB │   2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │    28 KiB │    28 KiB │    0 B 
      res │   1.7 MiB │   1.7 MiB │    0 B │     2 MiB │     2 MiB │    0 B 
   native │  18.8 KiB │  18.8 KiB │    0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │ 218.4 KiB │ 218.4 KiB │   +1 B │ 464.6 KiB │ 464.6 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  29.2 MiB │  29.2 MiB │ +421 B │  80.6 MiB │  80.6 MiB │ +872 B 

@ahmedre ahmedre added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c380163 Dec 5, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_bookmarks branch December 5, 2024 22:14
@ahmedre ahmedre mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant