-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dual pages on foldable devices #2670
Add support for dual pages on foldable devices #2670
Conversation
@@ -33,7 +33,7 @@ object PagerActivityModule { | |||
@Provides | |||
@ActivityScope | |||
fun provideImageWidth(@ActivityContext context: Context, screenInfo: QuranScreenInfo): String { | |||
return if (QuranUtils.isDualPages(context, screenInfo)) { | |||
return if (QuranUtils.isDualPages(context, screenInfo, false)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no way of injecting this value here so ignoring it for now. @ahmedre Could you elaborate a bit more on the use case here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline, moving forward, will consider moving this check into QuranScreenInfo
if possible.
|
Goal
Support dual pages on foldable devices while the orientation is still portrait. This will only be supported on foldable devices that fold horizontally.
Screenshot