Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foldables #1553

Closed
ahmedre opened this issue Feb 26, 2021 · 3 comments
Closed

Foldables #1553

ahmedre opened this issue Feb 26, 2021 · 3 comments

Comments

@ahmedre
Copy link
Contributor

ahmedre commented Feb 26, 2021

Try on a foldable emulator to see what low hanging fruit / wins there are - might just be a matter of allowing dual page in portrait mode on these devices.
@amirian
Copy link

amirian commented Aug 14, 2023

no plan to display two pages on foldable devices?

@ahmedre
Copy link
Contributor Author

ahmedre commented Aug 14, 2023

it's already supported today - the reason I opened this issue is that the setting in options is "show two pages in landscape" - on some foldable devices, the crease is between pages in portrait not in landscape, so "show two pages in portrait" would be a better setting. keeping this open to figure out a way to kill this setting altogether and simplify it so it does the right thing based on available screen real estate.

@ahmedre ahmedre mentioned this issue Apr 21, 2024
Merged
@ahmedre
Copy link
Contributor Author

ahmedre commented Apr 21, 2024

Fixed by #2670 - جزاكم الله خيراً @kadirkid

@ahmedre ahmedre closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmedre @amirian