-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unmaintained actions-rs/* actions in CI workflows #1579
Conversation
Thanks! I see you've used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Can you also add a snippet to our Dependabot config to check Actions?
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
Basically all of the `actions-rs/*` actions are unmaintained. See <actions-rs/toolchain#216> for more information. Due to their age they generate several warnings in CI runs. To get rid of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`, and the occurrences of `actions-rs/cargo` are replaced by direct invocations of `cargo`.
I would not recommend to do this, because according to its creator that is unsupported:
@djc:
Yes, I could do this, too, if you want it, but I would prefer to do this in a separate pull request. Edit: And there's the PR for the Dependabot configuration: #1580 |
Ah, good catch. Why |
|
Basically all of the
actions-rs/*
actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/quinn-rs/quinn/actions/runs/5100061676:To get rid of some of those warnings the occurrences of
actions-rs/toolchain
are replaced bydtolnay/rust-toolchain
, and the occurrences ofactions-rs/cargo
are replaced by direct invocations ofcargo
.