Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained actions-rs/* actions in CI workflows #1579

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Replace unmaintained actions-rs/* actions in CI workflows #1579

merged 1 commit into from
Jun 2, 2023

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Jun 1, 2023

Basically all of the actions-rs/* actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/quinn-rs/quinn/actions/runs/5100061676:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of some of those warnings the occurrences of actions-rs/toolchain are replaced by dtolnay/rust-toolchain, and the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

@Ralith
Copy link
Collaborator

Ralith commented Jun 1, 2023

Thanks! I see you've used @master -- should this be @v1 for stability?

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Can you also add a snippet to our Dependabot config to check Actions?

- package-ecosystem: github-actions
  directory: "/"
  schedule:
    interval: weekly

.github/workflows/codecov.yml Outdated Show resolved Hide resolved
Basically all of the `actions-rs/*` actions are unmaintained. See
<actions-rs/toolchain#216> for more
information. Due to their age they generate several warnings in
CI runs.

To get rid of those warnings the occurrences of
`actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`,
and the occurrences of `actions-rs/cargo` are replaced by direct
invocations of `cargo`.
@striezel
Copy link
Contributor Author

striezel commented Jun 2, 2023

@Ralith:

Thanks! I see you've used @master -- should this be @v1 for stability?

I would not recommend to do this, because according to its creator that is unsupported:

The v1 tag only exists so that the action gets a page on https://github.com/marketplace/actions. (And it has to be a tag for that to happen.) I am not interested in updating it. master and all the other branches (stable, 1.65 etc) are the only supported and documented way to use the action.

@djc:
Concerning the Dependabot stuff:

Can you also add a snippet to our Dependabot config to check Actions?

- package-ecosystem: github-actions
  directory: "/"
  schedule:
    interval: weekly

Yes, I could do this, too, if you want it, but I would prefer to do this in a separate pull request.

Edit: And there's the PR for the Dependabot configuration: #1580

@Ralith
Copy link
Collaborator

Ralith commented Jun 2, 2023

I would not recommend to do this, because dtolnay/rust-toolchain#45 (comment):

Ah, good catch. Why @stable in some places an @master elsewhere though?

@djc
Copy link
Member

djc commented Jun 2, 2023

I would not recommend to do this, because dtolnay/rust-toolchain#45 (comment):

Ah, good catch. Why @stable in some places an @master elsewhere though?

@stable where we need the stable toolchain, @master where we explicitly select some other version.

@Ralith Ralith merged commit a604759 into quinn-rs:main Jun 2, 2023
@striezel striezel deleted the actions-rs-replacement branch June 2, 2023 22:35
@djc djc mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants