Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating v1 tag #45

Closed
taiki-e opened this issue Dec 3, 2022 · 2 comments
Closed

Consider updating v1 tag #45

taiki-e opened this issue Dec 3, 2022 · 2 comments

Comments

@taiki-e
Copy link

taiki-e commented Dec 3, 2022

When specifying the toolchain version with toolchain input option (e.g., when using the old nightly toolchain, when using matrix), I'm currently using the v1 tag of this action. (I don't want to use the master branch because I want to avoid breakage due to unreleased changes.)

However, the v1 tag does not seem to have been updated and I get "set-output command is deprecated and will be disabled soon" warnings which have already been fixed in other releases (branches).

Is it possible to update the v1 tag like other releases (branches)? (switching from tag to branch would also may work)
Or is the v1 tag considered deprecated and it is recommended to use the master branch which may contain unreleased changes or another branch?

@dtolnay
Copy link
Owner

dtolnay commented Dec 3, 2022

The v1 tag only exists so that the action gets a page on https://github.com/marketplace/actions. (And it has to be a tag for that to happen.) I am not interested in updating it. master and all the other branches (stable, 1.65 etc) are the only supported and documented way to use the action.

@taiki-e
Copy link
Author

taiki-e commented Dec 3, 2022

Oh, I didn't realize that was an unsupported usage in the first place. (As shown in the following image, pressing the button "Use the latest version" on the marketplace page will suggest the v1 tag.)

marketplace

Anyway, if it is not supported in the first place, this issue can be closed. (Although I may need to revisit the use of this action on a project I'm maintained in, but that is due to my somewhat pedantic sticking to the CI, and is probably not a general expectation for this action.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants