Replace unmaintained actions-rs/toolchain action in CI workflows #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 2, 2023
|
Thanks. We've been making this change elsewhere (e.g. RustCrypto/formats#887) but there are quite a few repos to update |
tarcieri
approved these changes
Mar 2, 2023
|
Hmm, I think GitHub Actions is having some issues... jobs are showing up as cancelled but without failures |
|
@striezel can you |
newpavlov
reviewed
Mar 3, 2023
Basically all of the `actions-rs/*` actions are unmaintained. See <actions-rs/toolchain#216> for more information. Due to their age they generate several warnings in CI runs. To get rid of some of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`.
striezel
force-pushed
the
actions-rs-toolchain-replacement
branch
from
d32c98e to
daa1894
Compare
Done and force pushed. And while I was at it, I also replaced the remaining |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically all of the
actions-rs/*actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/RustCrypto/hashes/actions/runs/3716377913:To get rid of some of those warnings the occurrences of
actions-rs/toolchainare replaced bydtolnay/rust-toolchain.