Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSO config removal in quilt3.admin.sso_config.set() #4098

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Aug 15, 2024

Description

TODO

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@sir-sigurd sir-sigurd requested a review from nl0 August 15, 2024 13:10
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.47%. Comparing base (4f81266) to head (33c4dd2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4098    +/-   ##
========================================
  Coverage   38.47%   38.47%            
========================================
  Files         723      723            
  Lines       33218    33219     +1     
  Branches     4879     4879            
========================================
+ Hits        12781    12782     +1     
+ Misses      19813    19289   -524     
- Partials      624     1148   +524     
Flag Coverage Δ
api-python 90.85% <100.00%> (+<0.01%) ⬆️
catalog 11.45% <ø> (ø)
lambda 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit ec1091f Aug 15, 2024
39 checks passed
@sir-sigurd sir-sigurd deleted the sso-config-docstrings branch August 15, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants